[SeongA] WEEK 06 solutions #1863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonjh1217
approved these changes
Aug 30, 2025
| var isEndOfWord: Bool = false | ||
| } | ||
|
|
||
| var root: TrieNode? |
There was a problem hiding this comment.
init일 때 TrieNode()로 넣어주기 때문에 optional일 필요가 없을 것 같아요
| } | ||
| currentNode = currentNode?.children[char] | ||
| if index == word.count - 1 { | ||
| currentNode?.isEndOfWord = true |
There was a problem hiding this comment.
마지막에 해주면 되는 거라서 포문 밖 24라인에 분기 없이 추가해도 됩니답!
| if num > lastValue { | ||
| tails.append(num) | ||
| } else { | ||
| if let index = tails.firstIndex(where: { $0 >= num }) { |
There was a problem hiding this comment.
firstIndex는 O(n)의 함수라 O(logn)인 binarySearch를 구현해보시는 것도 좋을 것 같습니다.
valid-parentheses/delight010.swift
Outdated
| let dictionary: [Character: Character] = [")":"(", "]":"[", "}":"{"] | ||
| var stack: [Character] = [] | ||
| for char in s { | ||
| if let closeBucket = dictionary[char] { |
There was a problem hiding this comment.
네이밍이 closeBucket이 아니라 openBucket이어야 할 것 같습니다
There was a problem hiding this comment.
지현님, 이해하기 쉽고 상세한 피드백들 너무 감사드립니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!